[ 
https://issues.apache.org/jira/browse/SOLR-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15179260#comment-15179260
 ] 

Shalin Shekhar Mangar commented on SOLR-8728:
---------------------------------------------

Thanks Noble. 
{code}
+      List<String> subSliceNames =  new ArrayList<>();
+      for (int i = 0; i < subSlices.size(); i++) subSliceNames.add(slice + "_" 
+ i);
{code}

This seems redundant because the "subSlices" list already has all the sub-slice 
names.

The rest looks good!

> Splitting a shard of a collection created with a rule fails with NPE
> --------------------------------------------------------------------
>
>                 Key: SOLR-8728
>                 URL: https://issues.apache.org/jira/browse/SOLR-8728
>             Project: Solr
>          Issue Type: Bug
>            Reporter: Shai Erera
>            Assignee: Noble Paul
>         Attachments: SOLR-8728.patch, SOLR-8728.patch
>
>
> Spinoff from this discussion: http://markmail.org/message/f7liw4hqaagxo7y2
> I wrote a short test which reproduces, will upload shortly.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to