[ https://issues.apache.org/jira/browse/SOLR-8745?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15180380#comment-15180380 ]
Scott Blum commented on SOLR-8745: ---------------------------------- Sure! This was necessary to get tests to pass. Lazy collection refs get created based on the children of /solr/collections, regardless of whether a state.json exists for that collection. So e.g. an empty /solr/collections/FOO will cause a lazy FOO collection to be created. If there's no state.json, ref.get() will return null. However, as an edge case, someone could have just added FOO to clusterstate.json as a stateformat 1 collection, and so we can refresh the legacy state to check. > Deprecate ZkStateReader.updateClusterState(), remove uses > --------------------------------------------------------- > > Key: SOLR-8745 > URL: https://issues.apache.org/jira/browse/SOLR-8745 > Project: Solr > Issue Type: Improvement > Components: SolrCloud > Affects Versions: 5.4.1 > Reporter: Scott Blum > Assignee: Shalin Shekhar Mangar > Labels: patch, performance, solrcloud > Attachments: SOLR-8745.patch > > > Forcing a full ZK cluster state update creates a lot of unnecessary work and > load at scale. We need to deprecate and remove existing callers. > - The one at the start of ClusterStateUpdater thread is fine, it's a one-time > thing. > - The one in OverseerCollectionMessageHandler is getting removed in SOLR-8722 > - The rest of them can be replaced with a version that only updates a single > collection; not everything! > Patch will be forthcoming. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org