On Mar 18, 2011, at 9:55 PM, Chris Hostetter wrote: > > Just out of curiosity, i notice that it seemms to be warning if the number > of NOTICE files doesn't match the number of jars, but not failing (since > not every jar requires a NOTICE file) > > isn't this something that could be simplifed by requiring that every jar > have a NOTICE file, and if the jar's license doesn't require a NOTICE, > then that file can just be blank? (or make the code verify that every jar > has either a NOTICE file or an empty NO_NOTICE_NEEDED file?)
I could drop that warning, as I do have explicit NOTICE checking in place. I kept it b/c I am not 100% sure yet on what needs a NOTICE file and what doesn't, so I wanted people to keep an eye out for it. I don't think we need to clutter the dirs with NO_NOTICE_NEEDED files. > > : Date: Fri, 18 Mar 2011 21:33:29 +0000 (UTC) > : From: "Grant Ingersoll (JIRA)" <[email protected]> > : Reply-To: [email protected] > : To: [email protected] > : Subject: [jira] Resolved: (LUCENE-2952) Make license checking/maintenance > : easier/automated > : > : > : [ > https://issues.apache.org/jira/browse/LUCENE-2952?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel > ] > : > : Grant Ingersoll resolved LUCENE-2952. > : ------------------------------------- > : > : Resolution: Fixed > : Fix Version/s: 4.0 > : 3.2 > : Assignee: Grant Ingersoll > : > : > Make license checking/maintenance easier/automated > : > -------------------------------------------------- > : > > : > Key: LUCENE-2952 > : > URL: https://issues.apache.org/jira/browse/LUCENE-2952 > : > Project: Lucene - Java > : > Issue Type: Improvement > : > Reporter: Grant Ingersoll > : > Assignee: Grant Ingersoll > : > Priority: Minor > : > Fix For: 3.2, 4.0 > : > > : > Attachments: LUCENE-2952.patch, LUCENE-2952.patch, > LUCENE-2952.patch, LUCENE-2952.patch, LUCENE-2952.patch, LUCENE-2952.patch, > LUCENE-2952.patch > : > > : > > : > Instead of waiting until release to check licenses are valid, we should > make it a part of our build process to ensure that all dependencies have > proper licenses, etc. > : > : -- > : This message is automatically generated by JIRA. > : For more information on JIRA, see: http://www.atlassian.com/software/jira > : > : --------------------------------------------------------------------- > : To unsubscribe, e-mail: [email protected] > : For additional commands, e-mail: [email protected] > : > : > > -Hoss > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > -------------------------- Grant Ingersoll http://www.lucidimagination.com/ Search the Lucene ecosystem docs using Solr/Lucene: http://www.lucidimagination.com/search --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
