[ https://issues.apache.org/jira/browse/LUCENE-7098?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15191527#comment-15191527 ]
Robert Muir commented on LUCENE-7098: ------------------------------------- I like the idea, but some minor style changes: * instead of maxPointCount, can we use 'total' or 'sum'. its not a max. i realize it includes deletions, but we can just indicate that with a comment... * can we not do the optimization for Integer.MAX_VALUE+1. I think thats being too sneaky! > BKDWriter should write ords as ints when possible during offline sort > --------------------------------------------------------------------- > > Key: LUCENE-7098 > URL: https://issues.apache.org/jira/browse/LUCENE-7098 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Assignee: Michael McCandless > Attachments: LUCENE-7098.patch > > > Today we write all ords as longs, since we support more than 2.1B values in > one segment, but the vast majority of the time an int would suffice. > We could look into vLong, but this quickly gets tricky because {{BKDWriter}} > needs random access to the file and we rely on fixed-width entries to do this > now. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org