[ 
https://issues.apache.org/jira/browse/LUCENE-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Martijn van Groningen updated LUCENE-7091:
------------------------------------------
    Attachment: LUCENE-7091.patch

Updated the patch with the good points that you've raised.

bq. It's a shame that SORTED & BINARY use a BytesRefHash (adds overhead) and 
ultimately get sorted when, really, it's not necessary of course. The 
ByteBlockPool could be used directly to store it (see BytesRefArray for 
examples) with a little bit of code. This isn't a blocker but it would sure be 
nice.

Agreed, that would be nicer. I think we should do this in a follow up issue.

bq. Add term text here too, and under same field names as DV ones at that.

I think this is covered in 
TestMemoryIndexAgainstRAMDir#testDocValuesMemoryIndexVsNormalIndex() test, in 
this test regular fields are randomilly added.

> Add doc values support to MemoryIndex
> -------------------------------------
>
>                 Key: LUCENE-7091
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7091
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Martijn van Groningen
>         Attachments: LUCENE-7091.patch, LUCENE-7091.patch, LUCENE-7091.patch, 
> LUCENE-7091.patch, LUCENE-7091.patch, LUCENE-7091.patch, LUCENE-7091.patch
>
>
> Sometimes queries executed via the MemoryIndex require certain things to be 
> stored as doc values. Today this isn't possible because the memory index 
> doesn't support this and these queries silently return no results.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to