[
https://issues.apache.org/jira/browse/LUCENE-7091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15193364#comment-15193364
]
David Smiley commented on LUCENE-7091:
--------------------------------------
Almost there...
* (still applies to the _other_ addField): I think the javadocs sentence you
added to addField meant to use "if" not "is".
* At first I thought there might have been a bug for double-applying the boost
since I see you're still passing "boost" as a constructor argument to Info.
But now I see you only apply when numTokens > 0. I think it would be much
clearer (and simpler) to remove boost from the constructor to Info, and simply
apply it in storeTerms (no matter what numTokens is). It's hard to judge the
testDocValuesDoNotAffectBoostPositionsOrOffset for this problem... it'd get
encoded in the norm and I have no idea what norm it should be; your test
asserts -127. Hmmmm. Perhaps simply leave a check of that nature to the test
that asserts parity with the real index in RAMDirectory
* in {{storeDocValues()}} SORTED_NUMERIC: you call ArrayUtil.grow with only the
array. This results in the same {{O(N^2)}} we're trying to avoid! Pass in a
second argument of the desired length.
> Add doc values support to MemoryIndex
> -------------------------------------
>
> Key: LUCENE-7091
> URL: https://issues.apache.org/jira/browse/LUCENE-7091
> Project: Lucene - Core
> Issue Type: Improvement
> Reporter: Martijn van Groningen
> Attachments: LUCENE-7091.patch, LUCENE-7091.patch, LUCENE-7091.patch,
> LUCENE-7091.patch, LUCENE-7091.patch, LUCENE-7091.patch, LUCENE-7091.patch
>
>
> Sometimes queries executed via the MemoryIndex require certain things to be
> stored as doc values. Today this isn't possible because the memory index
> doesn't support this and these queries silently return no results.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
