[ 
https://issues.apache.org/jira/browse/SOLR-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15200780#comment-15200780
 ] 

Mark Miller commented on SOLR-4509:
-----------------------------------

I've just about got a new patch ready to show here.

I still don't have a decent way to hook into httpclient close anymore, so 
that's an issue that needs to be worked around outside of just tests (as I've 
done).

Some things to consider:

Supposedly the stale connection check is not as bad a performance killer as it 
used to be as it's not done every request any longer?
Without the stale check, when a server drops, even if it comes back up, the 
client might try to use a bad connection - in the past the stale connection 
check could catch that.
However, the stale connection check is still not 100% reliable and I assume the 
perf optimization that did has a similar issue as above in the right 
circumstance.
It still would be nice to try and control connection lifecycle from the client 
as much as possible.

> Disable HttpClient stale check for performance.
> -----------------------------------------------
>
>                 Key: SOLR-4509
>                 URL: https://issues.apache.org/jira/browse/SOLR-4509
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>         Environment: 5 node SmartOS cluster (all nodes living in same global 
> zone - i.e. same physical machine)
>            Reporter: Ryan Zezeski
>            Assignee: Mark Miller
>            Priority: Minor
>             Fix For: 5.0, master
>
>         Attachments: IsStaleTime.java, SOLR-4509-4_4_0.patch, 
> SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch, 
> SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch, 
> SOLR-4509.patch, baremetal-stale-nostale-med-latency.dat, 
> baremetal-stale-nostale-med-latency.svg, 
> baremetal-stale-nostale-throughput.dat, baremetal-stale-nostale-throughput.svg
>
>
> By disabling the Apache HTTP Client stale check I've witnessed a 2-4x 
> increase in throughput and reduction of over 100ms.  This patch was made in 
> the context of a project I'm leading, called Yokozuna, which relies on 
> distributed search.
> Here's the patch on Yokozuna: https://github.com/rzezeski/yokozuna/pull/26
> Here's a write-up I did on my findings: 
> http://www.zinascii.com/2013/solr-distributed-search-and-the-stale-check.html
> I'm happy to answer any questions or make changes to the patch to make it 
> acceptable.
> ReviewBoard: https://reviews.apache.org/r/28393/



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to