[ https://issues.apache.org/jira/browse/LUCENE-7123?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15204492#comment-15204492 ]
ASF subversion and git services commented on LUCENE-7123: --------------------------------------------------------- Commit c49e761c1bac84efa1e92a6a7b0f2169bba2612a in lucene-solr's branch refs/heads/branch_6_0 from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=c49e761 ] LUCENE-7123: deduplicate/cleanup spatial distance > deduplicate/cleanup spatial distance > ------------------------------------ > > Key: LUCENE-7123 > URL: https://issues.apache.org/jira/browse/LUCENE-7123 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Fix For: master, 6.0 > > Attachments: LUCENE-7123.patch, LUCENE-7123.patch > > > Currently there is a bit of a mess here: SloppyMath.haversin is slightly > different from GeoDistanceUtils.haversin, the latter is actually slightly > faster and uses a simple fixed earth diameter (which makes calculations > easier too). > But one of these returns meters, the other kilometers. Furthermore > lucene/spatial now uses some sin/tan functions that were added to sloppymath > with some accuracy guarantees (which are untested, and not quite correct). > Lucene/spatial queries also inconsistently mix the two different functions > together for various purposes and this just causes headaches. Its tests did > this recently too. > We need to clean this up, otherwise users will be confused. E.G. they will > see different results from expressions than from queries and not understand. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org