[ https://issues.apache.org/jira/browse/LUCENE-7125?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15205630#comment-15205630 ]
ASF subversion and git services commented on LUCENE-7125: --------------------------------------------------------- Commit e4359aadf278ce88b12d3d0bb522c26fcef1c597 in lucene-solr's branch refs/heads/branch_6x from [~rcmuir] [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=e4359aa ] LUCENE-7125: remove BKD_TOLERANCE from LatLonPoint polygon tests > remove BKD_TOLERANCE from LatLonPoint polygon tests > --------------------------------------------------- > > Key: LUCENE-7125 > URL: https://issues.apache.org/jira/browse/LUCENE-7125 > Project: Lucene - Core > Issue Type: Bug > Reporter: Robert Muir > Attachments: LUCENE-7125.patch > > > Currently this rejects any rectangles within a delta as being "too close to > an edge", and returns null, which means those are not tested in the random > test. > But we already compensate for quantization in the test, we should just remove > this additional delta. > The only problem I found in beasting is that, due to the algorithm being used > for polygons, it obeys the "definition of insideness" described here: > https://docs.oracle.com/javase/7/docs/api/java/awt/Shape.html > In my opinion, this test should work just like the distance test, and just > ensure the query is consistent with {{GeoRelationUtils.pointInPolygon()}}. > Anything the query is doing other than running that in brute-force is purely > an optimization. This also makes it easier to test more interesting polygons > in the future other than just rectangles. > Separately, we can test that this basic method works correctly better if we > want, but that can just be a unit test. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org