: I also think having large changes broken up is useful, even when not
: viewing with first parent. But it's a judgement call. If I have a tiny
: commit, and I tweak it maybe from a review comment, then I will usually
: squash. If I have a large commit I am working on, I try to make each commit
: make sense on its own, and I don't usually make lots of tiny commits.
: Again, that is just my style, so for me, keeping that history is useful.

gotcha - yeah.  

In this case though, the branch has lots of tiny commits -- not because i 
thought they were good and self contained, but because i was having 
problems and wanted to share the current state with folks to seek feedback 
& help in diagnosing problems.

(i can think of at least 5 commits i would have happily squashed via 
"git-rebase -i" once i figured out why something was broken -- but i'd 
already pushed to get feedback to try and understand why it was broken)


: If you feel more comfortable squashing into one commit, go for it. I was
: only trying to explain why I thought it *can* be useful.

I appreciate that ... the --first-parent tip in particular is a good note, 
but ultimately (at least in this case) i think squashing makes the most 
sense.

Thanks guys.


-Hoss
http://www.lucidworks.com/

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to