[ 
https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15217140#comment-15217140
 ] 

Michael McCandless commented on LUCENE-7150:
--------------------------------------------

Whoa, with this patch, I'm getting close to the hit counts I see with the geo2d 
impls (383M), even when using WGS84!  Thank you [~daddywri]!

It's 383,371,877 with geo3d and 382,961,953 with geopoint, which is much closer 
than I've ever seen.

Maybe we can share this constant for the earth?: 
https://github.com/apache/lucene-solr/commit/9c98f9d95801fe6e64f7653667feb30ed80b9b8e#diff-ff4af375ef79ebff087ad91ce7778959R136

Can we just use {{Math.toRadians}}?  Clearly I should not be trusted to write 
my own {{toRadians}} ;)

> geo3d public APIs should match the 2D apis?
> -------------------------------------------
>
>                 Key: LUCENE-7150
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7150
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>         Attachments: LUCENE-7150.patch
>
>
> I'm struggling to benchmark the equivalent to 
> {{LatLonPoint.newDistanceQuery}} in the geo3d world.
> Ideally, I think we'd have a {{Geo3DPoint.newDistanceQuery}}?  And it would 
> take degrees, not radians, and radiusMeters, not an angle?
> And if I index and search using {{PlanetModel.SPHERE}} I think it should 
> ideally give the same results as {{LatLonPoint.newDistanceQuery}}, which uses 
> haversin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to