[ https://issues.apache.org/jira/browse/SOLR-8725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218150#comment-15218150 ]
Erick Erickson commented on SOLR-8725: -------------------------------------- [~anshumg] I made this a blocker in response to the move to cut 6.0 to be sure we consciously decide to include this or not... The revised regex is a little easier to understand I think, but whatever.... Maybe a comment about what the purpose of the regex is (i.e. exclude a hyphen as the first character)? And maybe add the fact that they cannot _start_ with hypens to the getIdentifierMessage? > Cores, collections, and shards should accept hyphens in identifier name > ----------------------------------------------------------------------- > > Key: SOLR-8725 > URL: https://issues.apache.org/jira/browse/SOLR-8725 > Project: Solr > Issue Type: Bug > Affects Versions: 5.5 > Reporter: Chris Beer > Assignee: Anshum Gupta > Priority: Blocker > Fix For: master, 6.0, 5.5.1 > > Attachments: SOLR-8725-5_5.patch, SOLR-8725-fix-regex.patch, > SOLR-8725.patch, SOLR-8725.patch > > > In SOLR-8642, hyphens are no longer considered valid identifiers for cores > (and collections?). Our solr instance was successfully using hyphens in our > core names, and our affected cores now error with: > marc-profiler_shard1_replica1: > org.apache.solr.common.SolrException:org.apache.solr.common.SolrException: > Invalid name: 'marc-profiler_shard1_replica1' Identifiers must consist > entirely of periods, underscores and alphanumerics > Before starting to rename all of our collections, I wonder if this decision > could be revisited to be backwards compatible with previously created > collections. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org