[ https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218211#comment-15218211 ]
Ryan Ernst edited comment on LUCENE-7150 at 3/30/16 4:00 PM: ------------------------------------------------------------- Thanks for the patch [~daddywri]! I'm a little confused about the use of a constant for radians to meters, that assumes a sphere model right? Yet the patch uses the WGS84 planet model, which is a spheroid? If we are going to start with a this simple approach (which is perfect!) should the query use PlanetModel.SPHERE? I also think using the same constant that we calculate for haversin is important? We currently have this defined as 6_378_137 meters for the radius in GeoUtils (Mike, +1 to sharing this so we don't redefine this stuff multiple times). If we use that constant, and a sphere model, then presumably we should get the exact same hit counts right? was (Author: rjernst): Thanks for the patch [~daddywri]! I'm a little confused about the use of a constant for radians to meters, that assumes a sphere model right? Yet the patch uses the WGS84 planet model, which is a spheroid? If we are going to start with a this simple approach (which is perfect!) should the query use PlanetMode.SPHERE? I also think using the same constant that we calculate for haversin is important? We currently have this defined as 6_378_137 meters for the radius in GeoUtils (Mike, +1 to sharing this so we don't redefine this stuff multiple times). If we use that constant, and a sphere model, then presumably we should get the exact same hit counts right? > geo3d public APIs should match the 2D apis? > ------------------------------------------- > > Key: LUCENE-7150 > URL: https://issues.apache.org/jira/browse/LUCENE-7150 > Project: Lucene - Core > Issue Type: Improvement > Reporter: Michael McCandless > Attachments: LUCENE-7150.patch, LUCENE-7150.patch, LUCENE-7150.patch > > > I'm struggling to benchmark the equivalent to > {{LatLonPoint.newDistanceQuery}} in the geo3d world. > Ideally, I think we'd have a {{Geo3DPoint.newDistanceQuery}}? And it would > take degrees, not radians, and radiusMeters, not an angle? > And if I index and search using {{PlanetModel.SPHERE}} I think it should > ideally give the same results as {{LatLonPoint.newDistanceQuery}}, which uses > haversin. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org