[ 
https://issues.apache.org/jira/browse/SOLR-2436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010112#comment-13010112
 ] 

Tommaso Teofili edited comment on SOLR-2436 at 3/23/11 1:26 PM:
----------------------------------------------------------------

Hello Koji,
I've tested your patch, I needed to align it to latest patch applied (see 
SOLR-2387) to make tests work (see attached patch). 

In my opinion the solution you're proposing is better than the current one as 
it reflects the Solr way of specifying parameters in Handlers.

However I think it should be good if it was possible to alternatively get rid 
of the uimaConfig file defining each parameter inside the Processor with Solr 
elements (str/lst/int etc.) as well.



      was (Author: teofili):
    Hello Koji,
I've tested your patch, I needed to align it to latest patch applied (see 
SOLR-2387) to make tests work (see attached patch). 

In my opinion this solution is better than the current one as it reflects the 
Solr way of specifying parameters in Handlers.

However I think it should be good if it was possible to alternatively get rid 
of the uimaConfig file defining each parameter inside the Processor with Solr 
elements (str/lst/int etc.) as well.


  
> move uimaConfig to under the uima's update processor in solrconfig.xml
> ----------------------------------------------------------------------
>
>                 Key: SOLR-2436
>                 URL: https://issues.apache.org/jira/browse/SOLR-2436
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: 3.1
>            Reporter: Koji Sekiguchi
>            Priority: Minor
>         Attachments: SOLR-2436.patch, SOLR-2436.patch, SOLR-2436_2.patch
>
>
> Solr contrib UIMA has its config just beneath <config>. I think it should 
> move to uima's update processor tag.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to