[
https://issues.apache.org/jira/browse/LUCENE-6938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15218995#comment-15218995
]
Shawn Heisey commented on LUCENE-6938:
--------------------------------------
Apologies for the incorrect credit.
I've never done it, but ReleaseTodo seems to indicate that running addVersion
is done as one of the early steps in the process.
For major and minor releases, I think this makes sense, because you'll be
making a new branch early in the process. At that point the parent branch
should get a version bump, and the subsequent release work will be done in the
new branch, presumably with the correct version number already present.
For bugfix releases, I think it makes more sense to run addVersion just after
tagging the release -- one of the *last* steps. That would have prevented the
problem I ran into. I ran "ant package" on branch_5_5 some time after 5.5.0
was fully released, but I got 5.5.0-SNAPSHOT filenames instead of
5.5.1-SNAPSHOT.
Regarding the brand-new bug-fix Version entry being deprecated: This makes no
sense to me, especially since it causes an immediate test failure in the test
that the addVersion script runs after making changes. I can see with "git
diff" that the script did correctly add deprecation annotations to LUCENE_5_5_0.
If the addVersion script were being used to add 5.5.1 to one of the 6x branches
or the master branch, then it WOULD make sense for the new entry to be
deprecated. Perhaps I was not using the script correctly for my use case, or
the script needs some detection code or the option you mentioned to skip
deprecation.
> Convert build to work with Git rather than SVN.
> -----------------------------------------------
>
> Key: LUCENE-6938
> URL: https://issues.apache.org/jira/browse/LUCENE-6938
> Project: Lucene - Core
> Issue Type: Task
> Reporter: Mark Miller
> Assignee: Mark Miller
> Fix For: master, 5.x
>
> Attachments: LUCENE-6938-1.patch, LUCENE-6938-wc-checker.patch,
> LUCENE-6938-wc-checker.patch, LUCENE-6938.patch, LUCENE-6938.patch,
> LUCENE-6938.patch, LUCENE-6938.patch
>
>
> We assume an SVN checkout in parts of our build and will need to move to
> assuming a Git checkout.
> Patches against https://github.com/dweiss/lucene-solr-svn2git from
> LUCENE-6933.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
