[ 
https://issues.apache.org/jira/browse/LUCENE-7150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15219915#comment-15219915
 ] 

Michael McCandless commented on LUCENE-7150:
--------------------------------------------

Thanks [~daddywri], I think the last patch looks good.

This is a great step forward in usability for geo3d.  I'll add TODO and 
reference LUCENE-7152 about validating lat/lon values, and add some javadocs 
for the new methods.

I think for now we should leave the default planet model at WGS84, and just 
explain in the javadocs that there is up to 0.5% error.

> geo3d public APIs should match the 2D apis?
> -------------------------------------------
>
>                 Key: LUCENE-7150
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7150
>             Project: Lucene - Core
>          Issue Type: Improvement
>            Reporter: Michael McCandless
>         Attachments: LUCENE-7150-sphere.patch, LUCENE-7150.patch, 
> LUCENE-7150.patch, LUCENE-7150.patch, LUCENE-7150.patch, LUCENE-7150.patch
>
>
> I'm struggling to benchmark the equivalent to 
> {{LatLonPoint.newDistanceQuery}} in the geo3d world.
> Ideally, I think we'd have a {{Geo3DPoint.newDistanceQuery}}?  And it would 
> take degrees, not radians, and radiusMeters, not an angle?
> And if I index and search using {{PlanetModel.SPHERE}} I think it should 
> ideally give the same results as {{LatLonPoint.newDistanceQuery}}, which uses 
> haversin.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to