[ 
https://issues.apache.org/jira/browse/LUCENE-2977?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010263#comment-13010263
 ] 

Shai Erera commented on LUCENE-2977:
------------------------------------

Patch looks good !

In StreamUtils you have "<b>.bz</b>" -- it should be "<b>.bz2</b>"

bq. Any opinions on removing this "force-bzip" option?

+1 (you mean the bzip.compression property in WLDT right?). I think that it's 
reasonable to request the user to specify an output file with .bz2 extension if 
he wants bzip compression. I don't see how it will simplify StreamUtils though, 
but I trust you :) (perhaps you meant it will simplify WLDT?)

> WriteLineDocTask should write gzip/bzip2/txt according to the extension of 
> specified output file name
> -----------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-2977
>                 URL: https://issues.apache.org/jira/browse/LUCENE-2977
>             Project: Lucene - Java
>          Issue Type: Improvement
>          Components: contrib/benchmark
>            Reporter: Doron Cohen
>            Assignee: Doron Cohen
>            Priority: Minor
>             Fix For: 3.2, 4.0
>
>         Attachments: LUCENE-2977.patch
>
>
> Since the readers behave this way it would be nice and handy if also this 
> line writer would.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to