[
https://issues.apache.org/jira/browse/SOLR-4509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15220332#comment-15220332
]
Noble Paul commented on SOLR-4509:
----------------------------------
I think we should make these interfaces instead of abstract classes. Before
Java 8 we could not add methods to interfaces w/o breaking compatibility. So,
we always created abstract base classes . Now that we have moved to java 8 we
can add methods at will
{code}
public static abstract class HttpRequestInterceptorProvider {
public abstract HttpRequestInterceptor getHttpRequestInterceptor();
}
public static abstract class CredentialsProviderProvider {
public abstract CredentialsProvider getCredentialsProvider();
}
public static abstract class AuthSchemeRegistryProvider {
public abstract Lookup<AuthSchemeProvider> getAuthSchemeRegistry();
}
public static abstract class CookieSpecRegistryProvider {
public abstract Lookup<CookieSpecProvider> getCookieSpecRegistry();
}
{code}
> Move to non deprecated HttpClient impl classes to remove stale connection
> check on every request and move connection lifecycle management towards the
> client.
> -------------------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-4509
> URL: https://issues.apache.org/jira/browse/SOLR-4509
> Project: Solr
> Issue Type: Improvement
> Components: search
> Environment: 5 node SmartOS cluster (all nodes living in same global
> zone - i.e. same physical machine)
> Reporter: Ryan Zezeski
> Assignee: Mark Miller
> Priority: Minor
> Fix For: 5.0, master
>
> Attachments:
> 0001-SOLR-4509-Move-to-non-deprecated-HttpClient-impl-cla.patch,
> 0001-SOLR-4509-Move-to-non-deprecated-HttpClient-impl-cla.patch,
> 0001-SOLR-4509-Move-to-non-deprecated-HttpClient-impl-cla.patch,
> 0001-SOLR-4509-Move-to-non-deprecated-HttpClient-impl-cla.patch,
> 0001-SOLR-4509-Move-to-non-deprecated-HttpClient-impl-cla.patch,
> 0001-SOLR-4509-Move-to-non-deprecated-HttpClient-impl-cla.patch,
> IsStaleTime.java, SOLR-4509-4_4_0.patch, SOLR-4509.patch, SOLR-4509.patch,
> SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch,
> SOLR-4509.patch, SOLR-4509.patch, SOLR-4509.patch,
> baremetal-stale-nostale-med-latency.dat,
> baremetal-stale-nostale-med-latency.svg,
> baremetal-stale-nostale-throughput.dat, baremetal-stale-nostale-throughput.svg
>
>
> By disabling the Apache HTTP Client stale check I've witnessed a 2-4x
> increase in throughput and reduction of over 100ms. This patch was made in
> the context of a project I'm leading, called Yokozuna, which relies on
> distributed search.
> Here's the patch on Yokozuna: https://github.com/rzezeski/yokozuna/pull/26
> Here's a write-up I did on my findings:
> http://www.zinascii.com/2013/solr-distributed-search-and-the-stale-check.html
> I'm happy to answer any questions or make changes to the patch to make it
> acceptable.
> ReviewBoard: https://reviews.apache.org/r/28393/
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
