[
https://issues.apache.org/jira/browse/LUCENE-7145?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-7145.
---------------------------------
Resolution: Fixed
Fix Version/s: 6.1
master
These were cleaned up in LUCENE-7153
See my followup issue: LUCENE-7159. We may want to restore these methods and
replace Polygon's {{precise}} impls with the previous {{approximate}} versions
if edge case testing shows they are acceptable (or can be fixed to be) and
faster/simpler. But we need those tests first.
> We need only one set of polygon util methods
> --------------------------------------------
>
> Key: LUCENE-7145
> URL: https://issues.apache.org/jira/browse/LUCENE-7145
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Fix For: master, 6.1
>
>
> LatLonPoint methods are calling {{*precise()}} methods such as
> rectCrossesPolyPrecise(). GeoPointMethods are calling {{*approx()}} methods
> such as rectCrossesPolyApprox().
> I don't understand why we have two versions of these methods, why one is
> approximate, why we would ever use that, etc.
> These geo methods are extremely expensive: we can't afford two copies. For
> example, in the case of these polygon methods, they are still missing direct
> tests. We need to remove one copy of these. I propose to remove the approx
> ones.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
