[ 
https://issues.apache.org/jira/browse/LUCENE-7167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15223283#comment-15223283
 ] 

Karl Wright edited comment on LUCENE-7167 at 4/3/16 1:27 PM:
-------------------------------------------------------------

This clause was added to the test alone, because the quantization can, in 
theory, pull a point  to a slightly different place, and therefore the test 
(which bases its evaluation on the raw, unquantized point) can falsely claim 
that the point should be in (when it shouldn't) or out (when it shouldn't).  
Once the point is indexed though the quantized (x,y,z) *is* the benchmark, not 
the raw unquantized value.  Geo3D is correct either way -- it doesn't lie, it 
tells you whether the point is on or out, period.

So what you are looking at is code explicitly for testing, nothing more.

[~mikemccand]: You wrote the test -- can you help clarify please?



was (Author: kwri...@metacarta.com):
This clause was added to the test alone, because the quantization can, in 
theory, pull a point  to a slightly different place, and therefore the test 
(which bases its evaluation on the raw, unquantized point) can falsely claim 
that the point should be in (when it shouldn't) or out (when it shouldn't).  
Once the point is indexed though the quantized (x,y,z) *is* the benchmark, not 
the raw unquantized value.  Geo3D is correct either way -- it doesn't lie, it 
tells you whether the point is on or out, period.

So what you are looking at is code explicitly for testing, nothing more.


> Re-engineer or remove all of geo3D
> ----------------------------------
>
>                 Key: LUCENE-7167
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7167
>             Project: Lucene - Core
>          Issue Type: Task
>            Reporter: Karl Wright
>
> Geo3D has led to a lot of consternation because it has a relatively open API. 
>  The task is to either drastically restrict it or remove the package entirely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to