[
https://issues.apache.org/jira/browse/SOLR-8873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15225043#comment-15225043
]
Tomás Fernández Löbbe commented on SOLR-8873:
---------------------------------------------
Thanks for your comments [~janhoy]
With this change I'd like to address two things:
* Make sure none of our features will break due to some unexpected character in
the path by adding tests.
* Prevent special characters that could cause unexpected behavior either in our
UI or third party software.
bq. In Norway we have the special characters æøå...
That is exactly what I'm NOT trying to prevent (although my proposed regexp
does), but things like {{C:/opt/foo=bar('1','*')}}
Yes, someone needs admin rights to create a collection with that path, but my
rationale is: since I don't think those characters are needed in real
situations, why support them? Maybe we can go the other way and just block some
characters, but testing will be more difficult.
> Enforce dataDir/instanceDir/ulogDir to be paths that contain only a
> controlled subset of characters
> ---------------------------------------------------------------------------------------------------
>
> Key: SOLR-8873
> URL: https://issues.apache.org/jira/browse/SOLR-8873
> Project: Solr
> Issue Type: Improvement
> Reporter: Tomás Fernández Löbbe
> Attachments: SOLR-8873.patch
>
>
> We currently support any valid path for dataDir/instanceDir/ulogDir. I think
> we should prevent special characters and restrict to a subset that is
> commonly used and tested.
> My initial proposals it to allow the Java pattern:
> {code:java}"^[a-zA-Z0-9\\.\\ \\\\\\-_/\"':]+$"{code} but I'm open to
> suggestions. I'm not sure if there can be issues with HDFS paths (this
> pattern does pass the tests we currently have), or some other use case I'm
> not considering.
> I also think our tests should use all those characters randomly.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
