[
https://issues.apache.org/jira/browse/LUCENE-2990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13010816#comment-13010816
]
Simon Willnauer commented on LUCENE-2990:
-----------------------------------------
Uwe patch looks good.
I wonder if we could change the variable name from l to length or maybe size.
I had to look twice here
{code}
if (l <= 1) return;
{code}
to realize that you don't compare one <= one :)
> Improve ArrayUtil/CollectionUtil.*Sort() methods to early-reaturn on empty or
> one-element lists/arrays
> ------------------------------------------------------------------------------------------------------
>
> Key: LUCENE-2990
> URL: https://issues.apache.org/jira/browse/LUCENE-2990
> Project: Lucene - Java
> Issue Type: Improvement
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Priority: Trivial
> Fix For: 3.2, 4.0
>
> Attachments: LUCENE-2990.patch, LUCENE-2990.patch, LUCENE-2990.patch
>
>
> It might be a good idea to make CollectionUtil or ArrayUtil return early if
> the passed-in list or array's length <= 1 because sorting is unneeded then.
> This improves maybe automaton or other places, as for empty or one-element
> lists no SorterTermplate is created.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
