[ 
https://issues.apache.org/jira/browse/LUCENE-7208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238902#comment-15238902
 ] 

Dawid Weiss commented on LUCENE-7208:
-------------------------------------

Not to heat the discussion, but think of Automaton as the "source code" and 
RunAutomaton as the "binary, executable" version of this source code, David. 
RunAutomaton is essentially optimized for execution, it's not meant to link or 
carry the "source" with it -- that's one of the reasons it's decoupled from 
Automaton in Brics.

> Expose Automaton getter on RunAutomaton
> ---------------------------------------
>
>                 Key: LUCENE-7208
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7208
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: core/FSTs
>            Reporter: David Smiley
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE_7208.patch
>
>
> RunAutomaton is (of course) built from an Automaton and it stores it on a 
> field, package-private.  It would be convenient to expose it via a getter.  
> In fact CompiledAutomaton wants it.
> While we're at it, lets mark all the fields private and ensure that the only 
> classes using its state (currently its 2 subclasses) use the getters that 
> already exist for what they need.  Those getters are already final so I don't 
> expect a performance impact.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to