[
https://issues.apache.org/jira/browse/SOLR-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob updated SOLR-8933:
----------------------------
Attachment: SOLR-8933.patch
bq. Which makes me think, actually, more than logging at Error level, we should
probably fail an assert there and prevent tests from passing. We are looking to
enforce this if we can - a logging indicator only would be worst case I think.
Yes! This makes sense to me, now that you bring it up. I'm not used to using
asserts on other projects, but they make sense here.
Attaching a patch that uses asserts instead of logging. (Should it do both, on
the off chance that testMode is enabled but asserts are disabled?)
I have not run the full test suite on this yet, I'll let it go overnight and
see what shakes out, but wanted to get the patch up for more eyes first.
> SolrDispatchFilter::consumeInput logs "Stream Closed" IOException
> -----------------------------------------------------------------
>
> Key: SOLR-8933
> URL: https://issues.apache.org/jira/browse/SOLR-8933
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.10.3
> Reporter: Mike Drob
> Assignee: Mark Miller
> Attachments: SOLR-8933.patch, SOLR-8933.patch, SOLR-8933.patch,
> SOLR-8933.patch, SOLR-8933.patch, SOLR-8933.patch, SOLR-8933.patch,
> SOLR-8933.patch, SOLR-8933.patch
>
>
> After SOLR-8453 we started seeing some IOExceptions coming out of
> SolrDispatchFilter with "Stream Closed" messages.
> It looks like we are indeed closing the request stream in several places when
> we really need to be letting the web container handle their life cycle. I've
> got a preliminary patch ready and am working on testing it to make sure there
> are no regressions.
> A very strange piece of this is that I have been entirely unable to reproduce
> it on a unit test, but have seen it on cluster deployment quite consistently.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
