[ https://issues.apache.org/jira/browse/SOLR-8988?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15241767#comment-15241767 ]
Keith Laban commented on SOLR-8988: ----------------------------------- I'm not sure who would be best to look at this. Maybe [~yo...@apache.org] or [~erike4...@yahoo.com] would be more familiar with this code path. Is there any reason this wouldn't work? > Improve facet.method=fcs performance in SolrCloud > ------------------------------------------------- > > Key: SOLR-8988 > URL: https://issues.apache.org/jira/browse/SOLR-8988 > Project: Solr > Issue Type: Improvement > Reporter: Keith Laban > Attachments: SOLR-8988.patch > > > This relates to SOLR-8559 -- which improves the algorithm used by fcs > faceting when {{facet.mincount=1}} > This patch allows {{facet.mincount}} to be sent as 1 for distributed queries. > As far as I can tell there is no reason to set {{facet.mincount=0}} for > refinement purposes . After trying to make sense of all the refinement logic, > I cant see how the difference between _no value_ and _value=0_ would have a > negative effect. > *Test perf:* > - ~15million unique terms > - query matches ~3million documents > *Params:* > {code} > facet.mincount=1 > facet.limit=500 > facet.method=fcs > facet.sort=count > {code} > *Average Time Per Request:* > - Before patch: ~20seconds > - After patch: <1 second > *Note*: all tests pass and in my test, the output was identical before and > after patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org