[
https://issues.apache.org/jira/browse/SOLR-8983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15245369#comment-15245369
]
Varun Thacker commented on SOLR-8983:
-------------------------------------
Hi Anshum,
Patch looks good!
Few comments on the patch:
1. Can we move the test to not use AbstractFullDistribZkTestBase and use
SolrCloudTestCase instead? It should make the test a lot faster in my
experience. The current test on my machine took 55s .
2. In testCreateCollectionCleanup() after we confirm that the collection
doesn't exist via the LIST api call, can we try to create a collection without
the bogus dataDir param to make sure it gets created successfully.
3. Maybe we can randomize what param we pass wrongly? We can try with a wrong
configName , try with legacyCloud=false etc. It might trigger different
artifacts which get left behind to give better test coverage?
4. A separate test which uses more than one replica so that we know all the
cores were cleaned up properly?
5. In OverseerCollectionMessageHandler there is one INFO and one WARN statement
with a similar message. Maybe we should just put across a message like "failed
to create collection. Cleaning up artifacts .." ?
6. The cleanup delete operation does not pass along the async param which might
have been used.
7. Slightly unrelated but in createCollection instead of catching Exception,
catching IOException should be enough and we don't even need to catch
SolrException ?
> Failed Collection CREATE call should cleanup the cluster state before
> returning
> -------------------------------------------------------------------------------
>
> Key: SOLR-8983
> URL: https://issues.apache.org/jira/browse/SOLR-8983
> Project: Solr
> Issue Type: Bug
> Affects Versions: 5.5, 6.0
> Reporter: Anshum Gupta
> Assignee: Anshum Gupta
> Fix For: 5.5.1, 6.1
>
> Attachments: SOLR-8983-test.patch, SOLR-8983.patch, SOLR-8983.patch,
> SOLR-8983.patch
>
>
> In case of a failed collection creation call, the cluster state is updated
> leaving an entry for the failed collection. This is also returned by the LIST
> command, allowing the users to believe that the collection exists.
> CREATE call should cleanup in case of a failed attempt at creating the
> collection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
