[ https://issues.apache.org/jira/browse/SOLR-8933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15246548#comment-15246548 ]
Uwe Schindler commented on SOLR-8933: ------------------------------------- Hi, I am fine with the way how it is handles by SolrRequestParsers. This was my only complaint. I do not take care if we should rely on streams not closed or keep them open, I was just afraid of resource leaks because ContentStreams were not closed anymore in earlier patches. But this is perfectly solved by commons-io CloseShield just inside SolrRequestParsers. For everything else (preventing closing of the underlying ServletStreams) inside SolrDispatchFilter: I have no strong preference. But code looks fine. I leave that open to You and Mark how to handle this.. > SolrDispatchFilter::consumeInput logs "Stream Closed" IOException > ----------------------------------------------------------------- > > Key: SOLR-8933 > URL: https://issues.apache.org/jira/browse/SOLR-8933 > Project: Solr > Issue Type: Bug > Affects Versions: 4.10.3 > Reporter: Mike Drob > Assignee: Mark Miller > Attachments: SOLR-8933.patch, SOLR-8933.patch, SOLR-8933.patch, > SOLR-8933.patch, SOLR-8933.patch, SOLR-8933.patch, SOLR-8933.patch, > SOLR-8933.patch, SOLR-8933.patch > > > After SOLR-8453 we started seeing some IOExceptions coming out of > SolrDispatchFilter with "Stream Closed" messages. > It looks like we are indeed closing the request stream in several places when > we really need to be letting the web container handle their life cycle. I've > got a preliminary patch ready and am working on testing it to make sure there > are no regressions. > A very strange piece of this is that I have been entirely unable to reproduce > it on a unit test, but have seen it on cluster deployment quite consistently. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org