[
https://issues.apache.org/jira/browse/SOLR-8823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15250010#comment-15250010
]
Kevin Risden commented on SOLR-8823:
------------------------------------
[~cahilltr] - Some initial comments:
What is the following trying to accomplish?
{code}
String where = sqlVistor.query.replace("(", "").replace(")", "").replace("\"",
"");
String[] splits = where.split(":");
String table = defaultWorkerCollection;
for (int i = 0 ; i < splits.length; i++) {
if (splits[i].contains("TABLE_NAME")){
table = splits[i+1];
}
}
{code}
Does getColumns need to go through all live nodes? How about just the nodes
that are serving that collection?
getUniqueKey should be able to short circuit and just return instead of having
to loop through all of the live nodes?
Are any of the strings like "TABLE_CAT" already available as constants instead
of using the strings everywhere?
> Implement DatabaseMetaDataImpl.getColumns(String catalog, String
> schemaPattern, String tableNamePattern, String columnNamePattern)
> ----------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8823
> URL: https://issues.apache.org/jira/browse/SOLR-8823
> Project: Solr
> Issue Type: Sub-task
> Components: SolrJ
> Affects Versions: master, 6.0
> Reporter: Kevin Risden
> Assignee: Kevin Risden
> Attachments: SOLR-8823.patch, SOLR-8823.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
