[
https://issues.apache.org/jira/browse/SOLR-9016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15252044#comment-15252044
]
Anshum Gupta commented on SOLR-9016:
------------------------------------
I think this makes sense. It adds more restrictions to the regular expression
that we currently have and so people who actually (for whatever reason) have
been creating collections with names like the ones you mentioned above would
run into issues but I think we shouldn't be worried about those use-cases.
I think this could also go into 5.5.1 unless there's someone who thinks this
wouldn't be the right time/release version. So, without any bike shedding, we
should skip this change only if there are any strong objections.
> SolrIdentifierValidator accepts empty names
> -------------------------------------------
>
> Key: SOLR-9016
> URL: https://issues.apache.org/jira/browse/SOLR-9016
> Project: Solr
> Issue Type: Bug
> Components: Server
> Reporter: Shai Erera
>
> SolrIdentifierValidator accepts shard, collection, cores and alias names
> following this pattern:
> {code}
> ^(?!\\-)[\\._A-Za-z0-9\\-]*$
> {code}
> This accepts an "empty" name. This is easily fixable by changing the {{\*}}
> to {{+}}. However, it also accepts names such as {{..}}, {{,__---}} etc. Do
> we not want to require collection names to have a letter/digit identifier in
> them? Something like the following pattern:
> {code}
> ^(\\.)?[a-zA-Z0-9]+[\\._\\-a-zA-Z0-9]*$
> {code}
> That pattern requires the name to start with an optional {{.}} followed by a
> series of letters/digits followed by the rest of the allowed characters.
> What do you think?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
