[
https://issues.apache.org/jira/browse/SOLR-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15255867#comment-15255867
]
Erick Erickson commented on SOLR-8467:
--------------------------------------
OK, I was able to beast the code for GraphExpressionTest and
StreamExpressionTest and they seem OK. Well, I am getting a lot of
"Unable to build keystore from file: null" errors, but I'm ignoring them so far.
I'm running full tests now, but I've attached a patch for what I currently
have, nocommits and all. You'll see a lot of commented-out code in
GatherNodeStream pending the resolution of my note from earlier today.
Meanwhile, are there objections to the approach? As I mentioned, I need to
clean some things up before committing, and I think SOLR-8925 needs to be
applied to 6x before this patch can go in....
I'd like to keep from getting too far out of date, last time I let it languish
I caused myself a lot of extra work as the underlying code is changing pretty
rapidly, so comments appreciated.
> CloudSolrStream and FacetStream should take a SolrParams object rather than a
> Map<String, String> to allow more complex Solr queries to be specified
> ----------------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-8467
> URL: https://issues.apache.org/jira/browse/SOLR-8467
> Project: Solr
> Issue Type: Improvement
> Reporter: Erick Erickson
> Assignee: Erick Erickson
> Attachments: SOLR-8467.patch, SOLR-8647.patch, SOLR-8647.patch
>
>
> Currently, it's impossible to, say, specify multiple "fq" clauses when using
> Streaming Aggregation due to the fact that the c'tors take a Map of params.
> Opening to discuss whether we should
> 1> deprecate the current c'tor
> and/or
> 2> add a c'tor that takes a SolrParams object instead.
> and/or
> 3> ???
> I don't see a clean way to go from a Map<String, String> to a
> (Modifiable)SolrParams, so existing code would need a significant change. I
> hacked together a PoC, just to see if I could make CloudSolrStream take a
> ModifiableSolrParams object instead and it passes tests, but it's so bad that
> I'm not going to even post it. There's _got_ to be a better way to do this,
> but at least it's possible....
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
