[
https://issues.apache.org/jira/browse/SOLR-9014?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15258576#comment-15258576
]
Scott Blum commented on SOLR-9014:
----------------------------------
Correct, the edge case is what we're guarding against here. I would be
completely on board with making collectionStates() cheap, but we would need to
go update all the call sites to guard against that edge case; ie, using a key
returned from collectionStates(), all the call sites need to expect that
getCollection(key) might return null.
> Deprecate and reduce usage of ClusterState methods which may make calls to ZK
> via the lazy collection reference
> ---------------------------------------------------------------------------------------------------------------
>
> Key: SOLR-9014
> URL: https://issues.apache.org/jira/browse/SOLR-9014
> Project: Solr
> Issue Type: Improvement
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Fix For: master, 6.1
>
> Attachments: SOLR-9014.patch
>
>
> ClusterState has a bunch of methods such as getSlice and getReplica which
> internally call getCollectionOrNull that ends up making a call to ZK via the
> lazy collection reference. Many classes use these methods even though a
> DocCollection object is available. In such cases, multiple redundant calls to
> ZooKeeper can happen if the collection is not watched locally. This is
> especially true for Overseer classes which operate on all collections.
> We should audit all usages of these methods and replace them with calls to
> appropriate DocCollection methods.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
