[ https://issues.apache.org/jira/browse/SOLR-9028?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Hoss Man updated SOLR-9028: --------------------------- Attachment: SOLR-9028.patch Updated patch... bq. I want to cleanup some of the SSLTestConfig methods that only exist in master and have weird side effects (introduced in SOLR-4509) done. bq. I think it might makes sense to promote the the SSLContext.getDefault/setDefault preservation to SolrTestCaseJ4 ... but i'm not 100% certain yet. Need to think it through more. I decided this is probably not a good idea -- no reason to add to the number of things SolrTestCaseJ4 is doing automagically w/o a need for it. ---- I think this is basically ready ... I'm going to hammer on tests w/it for a bit. > fix bugs in (add sanity checks for) SSL clientAuth testing > ---------------------------------------------------------- > > Key: SOLR-9028 > URL: https://issues.apache.org/jira/browse/SOLR-9028 > Project: Solr > Issue Type: Bug > Reporter: Hoss Man > Assignee: Hoss Man > Attachments: SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch, > SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch, os.x.failure.txt > > > While looking into SOLR-8970 i realized there was a whole heap of problems > with how clientAuth was being handled in tests. Notably: it wasn't actaully > being used when the randomization selects it (aparently due to a copy/paste > mistake in SOLR-7166). But there are few other misc issues (improper usage > of sysprops overrides for tests, missuage of keystore/truststore in test > clients, etc..) > I'm working up a patch to fix all of this, and add some much needed tests to > *explicitly* verify both SSL and clientAuth that will include some "false > positive" verifications, and some "test the test" checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org