[ https://issues.apache.org/jira/browse/SOLR-9027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15262381#comment-15262381 ]
Joel Bernstein edited comment on SOLR-9027 at 4/28/16 4:22 PM: --------------------------------------------------------------- [~dsmiley], I've been working on the changes you proposed. I dug into how the TermContext is being used elsewhere in Lucene. What I found was that the TermQuery is holding onto the TermContext and seems to be relying on wrapper queries to manage it properly. This is marked as an expert usage. The CommonTermsQuery uses this constructor. So it does appear that holding onto the TermContext is OK, as long as it's handled properly. So I'll review just to make sure the TermContexts are always regenerated when the query is run and continue to hold onto it within the query. was (Author: joel.bernstein): [~dsmiley], I've been working on the changes you proposed. I dug into how to the TermContext is being used elsewhere in Lucene. What I found was that the TermQuery is holding onto the TermContext and seems to be relying on wrapper queries to manage it properly. This is marked as an expert usage. The CommonTermsQuery uses this constructor. So it does appear that holding onto the TermContext is OK, as long as it's handled properly. So I'll review just to make sure the TermContexts are always regenerated when the query is run and continue to hold onto it within the query. > Add GraphTermsQuery to limit traversal on high frequency nodes > -------------------------------------------------------------- > > Key: SOLR-9027 > URL: https://issues.apache.org/jira/browse/SOLR-9027 > Project: Solr > Issue Type: New Feature > Reporter: Joel Bernstein > Priority: Minor > Attachments: SOLR-9027.patch, SOLR-9027.patch, SOLR-9027.patch, > SOLR-9027.patch > > > The gatherNodes() Streaming Expression is currently using a basic disjunction > query to perform the traversals. This ticket is to create a specific > GraphTermsQuery for performing the traversals. > The GraphTermsQuery will be based off of the TermsQuery, but will also > include an option for a docFreq cutoff. Terms that are above the docFreq > cutoff will not be included in the query. This will help users do a more > precise and efficient traversal. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org