Github user dragonsinth commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/32#discussion_r61507961
--- Diff:
solr/solrj/src/java/org/apache/solr/common/cloud/ZkStateReader.java ---
@@ -131,6 +132,19 @@
private final Runnable securityNodeListener;
+ private Map<String, CollectionWatch> collectionWatches = new
ConcurrentHashMap<>();
--- End diff --
The reason I made a comment about using the concrete type here is that it
makes it much easier to work with as a developer. When you can see that the
static type of this variable is ConcurrentHashMap, that helps you evaluate the
code that touches it.
For example, when you use IDE features to 'click through' a method call or
view the javadoc on a called method, you get the ConcurrentHashMap version of
the javadoc/method instead of the Map version, which helps you more easily
evaluate the correctness.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
