[
https://issues.apache.org/jira/browse/SOLR-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267585#comment-15267585
]
Hrishikesh Gadre commented on SOLR-9055:
----------------------------------------
>>Nitpick: In your editor, if it has this feature (IntelliJ does), configure it
>>to strip trailing whitespace only on Modified Lines. IntelliJ:
>>Editor/General/Other "Strip trailing spaces on Save".
Sorry about that. Let me resubmit the patch without this noise.
>>Does this API enable the possibility of a hard-link based copy (applicable
>>for both backup & restore). It doesn't seem so but I'm unsure?
The current "IndexBackupStrategy" API works at the Overseer level and not at
the "core" level. Since "hard-link" based copy needs to be done at the "core"
level, it doesn't handle this use-case.
>>Before committing to this API, it would be good to have it implement
>>something useful (HDFS or whatever), otherwise we very well may miss problems
>>with the API – we probably will. I'm not saying this issue needs to implement
>>HDFS, but at least the proposed patch might have an implementation specific
>>part in some separate files that wouldn't be committed with this issue. I
>>suppose this isn't strictly required but it would help.
My primary motivation was just to make the code modular (instead of having one
gigantic method incorporating all logic). But I agree that delaying the
interface definition would probably be better. So I can remove the
"IndexBackupStrategy" interface and have BackupManager use "CopyFilesStrategy"
by default. Would that be sufficient?
> Make collection backup/restore extensible
> -----------------------------------------
>
> Key: SOLR-9055
> URL: https://issues.apache.org/jira/browse/SOLR-9055
> Project: Solr
> Issue Type: Task
> Reporter: Hrishikesh Gadre
> Attachments: SOLR-9055.patch
>
>
> SOLR-5750 implemented backup/restore API for Solr. This JIRA is to track the
> code cleanup/refactoring. Specifically following improvements should be made,
> - Add Solr/Lucene version to check the compatibility between the backup
> version and the version of Solr on which it is being restored.
> - Add a backup implementation version to check the compatibility between the
> "restore" implementation and backup format.
> - Introduce a Strategy interface to define how the Solr index data is backed
> up (e.g. using file copy approach).
> - Introduce a Repository interface to define the file-system used to store
> the backup data. (currently works only with local file system but can be
> extended). This should be enhanced to introduce support for "registering"
> repositories (e.g. HDFS, S3 etc.)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
