Github user romseygeek commented on the pull request:
https://github.com/apache/lucene-solr/pull/32#issuecomment-216922168
> One thing I noticed in writing this is that it's uncertain whether you'll
miss any states or not
Unless I'm misunderstanding you, this is just how ZK works, though. A
watcher firing just means that there has been at least one change to the
watched node in the space of the last tick. So we wouldn't be able to
guarantee that the CollectionStateWatcher is notified of every change.
If we're making CSW public again, I don't think the queueing implementation
you have there will work? An executor seems to be the most straightforward way
of doing things here. Although, thinking more about that, we already have a
separate executor for watchers, don't we? So this may just be overthinking
things.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
