Github user romseygeek commented on a diff in the pull request:
https://github.com/apache/lucene-solr/pull/34#discussion_r62206298
--- Diff: solr/core/src/java/org/apache/solr/update/UpdateHandler.java ---
@@ -200,4 +187,16 @@ public void registerOptimizeCallback(
SolrEventListener listener )
}
public abstract void split(SplitIndexCommand cmd) throws IOException;
+
+ private static UpdateLog initialisePluginUpdateLog(SolrCore core, String
dataDir, PluginInfo ulogPluginInfo)
+ {
+ String className = ulogPluginInfo.className;
+ if (System.getProperty("test.hdfs.forceHdfsUpdateLog") != null) {
+ className = "solr.HdfsUpdateLog";
+ }
+ if (className != null) {
+ return core.getResourceLoader().newInstance(className,
UpdateLog.class);
+ }
+ return new UpdateLog();
+ }
}
--- End diff --
I wonder if a nicer way of doing this would be to make UpdateLog be created
by the DirectoryFactory? Something like:
```
DirectoryFactory {
public UpdateLog newUpdateLog(SolrCore core, String dataDir, PluginInfo
ulogPluginInfo) {
if (ulogPluginInfo.className == null)
return new UpdateLog();
return core.getResourceLoader().newInstance(ulogPluginInfo.className,
UpdateLog.class);
}
}
HdfsDirectoryFactory {
@Override
public UpdateLog newUpdateLog( ... ) {
if (ulogPluginInfo.className == null) {
return new HdfsUpdateLog();
}
return super.newUpdateLog( ... );
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
