[ 
https://issues.apache.org/jira/browse/SOLR-9055?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15274981#comment-15274981
 ] 

Hrishikesh Gadre commented on SOLR-9055:
----------------------------------------

[[email protected]]

I successfully refactored the "core backup" logic to use the Repository 
interface. But it looks like during "restore" operation we need to use Lucene 
API to compute the file checksum. This API unfortunately requires the Lucene 
Directory/IndexInput implementation.
https://github.com/apache/lucene-solr/blob/a5586d29b23f7d032e6d8f0cf8758e56b09e0208/solr/core/src/java/org/apache/solr/handler/RestoreCore.java#L83

Is there any other way to compute the checksum? Since without such support, we 
will need to implement Directory interface for each type of file-system we want 
to integrate with (and it makes Repository interface redundant). 

Also I didn't quite understand the logic in the following code-block,
https://github.com/apache/lucene-solr/blob/a5586d29b23f7d032e6d8f0cf8758e56b09e0208/solr/core/src/java/org/apache/solr/handler/RestoreCore.java#L88-L95

Why would we want to use the files in the "local" directory? In case of 
collection restoration, there will be no files (since we create a new core). I 
am not sure if I understand the actual problem here...


 



> Make collection backup/restore extensible
> -----------------------------------------
>
>                 Key: SOLR-9055
>                 URL: https://issues.apache.org/jira/browse/SOLR-9055
>             Project: Solr
>          Issue Type: Task
>            Reporter: Hrishikesh Gadre
>            Assignee: Mark Miller
>         Attachments: SOLR-9055.patch, SOLR-9055.patch
>
>
> SOLR-5750 implemented backup/restore API for Solr. This JIRA is to track the 
> code cleanup/refactoring. Specifically following improvements should be made,
> - Add Solr/Lucene version to check the compatibility between the backup 
> version and the version of Solr on which it is being restored.
> - Add a backup implementation version to check the compatibility between the 
> "restore" implementation and backup format.
> - Introduce a Strategy interface to define how the Solr index data is backed 
> up (e.g. using file copy approach).
> - Introduce a Repository interface to define the file-system used to store 
> the backup data. (currently works only with local file system but can be 
> extended). This should be enhanced to introduce support for "registering" 
> repositories (e.g. HDFS, S3 etc.)



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to