dooh -- yes, logic was backwards. Thank you random testing! (and Robert -- of course)
On Wed, Mar 30, 2011 at 4:32 PM, Robert Muir <[email protected]> wrote: > On Wed, Mar 30, 2011 at 4:22 PM, Ryan McKinley <[email protected]> wrote: >> int off = ref.offset; > ... >> if (off + buf.length > ref.length) { >> throw new InvalidShapeException("Asking for too many bytes"); > > this check looks like it might be wrong (backwards logic) especially > if the codec returns terms with nonzero bytesref offsets? > but its hard to tell in the context of your small snippet... > > --------------------------------------------------------------------- > To unsubscribe, e-mail: [email protected] > For additional commands, e-mail: [email protected] > > --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
