This should reduce the runtime of the tests by quite a bit as well :) On Fri, May 13, 2016 at 7:50 PM, David Smiley <[email protected]> wrote:
> Thanks for doing this! > > On Fri, May 13, 2016 at 5:36 AM Alan Woodward <[email protected]> wrote: > >> Hi all, >> >> We currently have 109 tests in solr that extend >> AbstractDistribZkTestBase. These all rely on 'legacy cloud' behaviour - >> the test creates a bunch of core directories and properties files, which >> then automagically instantiate a collection when they are loaded. This is >> behaviour that ideally we want to deprecate and remove, migrating >> everything to a 'ZK is truth' mode; the fact that almost all our >> cloud-based tests rely on this behaviour is a bit of a hindrance here. >> >> Starting next week, I'd like to migrate as many of these tests as >> possible to using SolrCloudTestCase instead. I'll move them in groups, >> creating individual JIRAs for each group, to break things down a bit. A >> lot of these tests are from the very early days of Solr Cloud, before many >> of the APIs were added, so they can probably be simplified at the same time. >> >> I migrated the SolrJ tests last week in SOLR-9065, and managed to tread >> on the toes of a bunch of people already working on them, so this is a >> heads-up to try and avoid that happening again. If anybody is actively >> working on a test that's derived from AbstractDistribZkTestBase, please let >> me know, and I can either hold off on migrating that test, or help out with >> moving it across. And of course, if anybody else wants to join in, then >> feel free :) >> >> Alan Woodward >> www.flax.co.uk >> >> >> -- > Lucene/Solr Search Committer, Consultant, Developer, Author, Speaker > LinkedIn: http://linkedin.com/in/davidwsmiley | Book: > http://www.solrenterprisesearchserver.com > -- Regards, Varun Thacker
