[ 
https://issues.apache.org/jira/browse/SOLR-9106?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Alan Woodward updated SOLR-9106:
--------------------------------
    Attachment: SOLR-9106.patch

Hm, so a couple of the tests complicate this a bit by calling ZkStateReader 
*without* setting up all the watches, etc (something that I want to make not 
possible in SOLR-9056).  To get around this, I've introduced a 
ClusterProperties class that will read and write properties in real-time, if 
need be.

I've also had to make the ZkController baseURL non-final, because it needs to 
be set *after* the state reader watches are created, and that isn't done in the 
constructor.  Which is annoying, but again SOLR-9056 cleans that up so I'm not 
too concerned.

All tests pass with this patch.

> Cache cluster properties in ZkStateReader
> -----------------------------------------
>
>                 Key: SOLR-9106
>                 URL: https://issues.apache.org/jira/browse/SOLR-9106
>             Project: Solr
>          Issue Type: Improvement
>    Affects Versions: master (7.0)
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>         Attachments: SOLR-9106.patch, SOLR-9106.patch
>
>
> ZkStateReader currently makes calls into ZK every time getClusterProps() is 
> called.  Instead we should keep the data locally and use a Watcher to update 
> it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to