[
https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15292265#comment-15292265
]
Tomás Fernández Löbbe commented on SOLR-7374:
---------------------------------------------
I came to this issue following the discussion in SOLR-9055. I really like this
patch. It should also allow future improvements (like making the backups
incremental) and since it's really low level most of the logic is in the
SnapShooter can be shared no matter what storage system is used.
Small comment. There seems to be a bug in {{BackupRepositoryFactory}}
{code:java|title=BackupRepositoryFactory.java}
if (isDefault && (this.defaultBackupRepoPlugin != null)) {
if (this.defaultBackupRepoPlugin != null) {
throw new SolrException(ErrorCode.SERVER_ERROR, "More than one backup
repository is configured as default");
}
this.defaultBackupRepoPlugin = backupRepoPlugins[i];
}
{code}
Some improvements to {{TestSolrXml}} could catch this?
I'd also add some more logging to this class, like {{logging.info("Adding
BackupRepositoryFactory foo");}}. Configuration is pretty open to mistakes that
are difficult to track.
> Backup/Restore should provide a param for specifying the directory
> implementation it should use
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-7374
> URL: https://issues.apache.org/jira/browse/SOLR-7374
> Project: Solr
> Issue Type: Bug
> Reporter: Varun Thacker
> Assignee: Varun Thacker
> Fix For: 5.2, 6.0
>
> Attachments: SOLR-7374.patch, SOLR-7374.patch
>
>
> Currently when we create a backup we use SimpleFSDirectory to write the
> backup indexes. Similarly during a restore we open the index using
> FSDirectory.open .
> We should provide a param called {{directoryImpl}} or {{type}} which will be
> used to specify the Directory implementation to backup the index.
> Likewise during a restore you would need to specify the directory impl which
> was used during backup so that the index can be opened correctly.
> This param will address the problem that currently if a user is running Solr
> on HDFS there is no way to use the backup/restore functionality as the
> directory is hardcoded.
> With this one could be running Solr on a local FS but backup the index on
> HDFS etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
