[ https://issues.apache.org/jira/browse/SOLR-9028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15294069#comment-15294069 ]
ASF subversion and git services commented on SOLR-9028: ------------------------------------------------------- Commit 9645d4213292121d2f011f5440684ea25d7beaa3 in lucene-solr's branch refs/heads/branch_6_0 from Chris Hostetter [ https://git-wip-us.apache.org/repos/asf?p=lucene-solr.git;h=9645d42 ] SOLR-9028: Fixed some test related bugs preventing SSL + ClientAuth from ever being tested (cherry picked from commit 791d1e7) Conflicts: solr/core/src/test/org/apache/solr/cloud/SSLMigrationTest.java solr/solrj/src/java/org/apache/solr/client/solrj/impl/HttpClientUtil.java solr/test-framework/src/java/org/apache/solr/SolrTestCaseJ4.java solr/test-framework/src/java/org/apache/solr/util/SSLTestConfig.java Conflicts: solr/core/src/test/org/apache/solr/cloud/TestMiniSolrCloudClusterSSL.java For branch_6_0: Since SOLR-8097 will land in 6.1, remove calls in TestMiniSolrCloudClusterSSL to SolrTestCaseJ4.getHttpSolrClient(). > fix bugs in (add sanity checks for) SSL clientAuth testing > ---------------------------------------------------------- > > Key: SOLR-9028 > URL: https://issues.apache.org/jira/browse/SOLR-9028 > Project: Solr > Issue Type: Bug > Reporter: Hoss Man > Assignee: Hoss Man > Fix For: 6.0.1, 6.1 > > Attachments: > SOLR-9028-branch_6_0-remove-httpclient-builder-method.patch, SOLR-9028.patch, > SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch, SOLR-9028.patch, > SOLR-9028.patch, os.x.failure.txt > > > While looking into SOLR-8970 i realized there was a whole heap of problems > with how clientAuth was being handled in tests. Notably: it wasn't actaully > being used when the randomization selects it (aparently due to a copy/paste > mistake in SOLR-7166). But there are few other misc issues (improper usage > of sysprops overrides for tests, missuage of keystore/truststore in test > clients, etc..) > I'm working up a patch to fix all of this, and add some much needed tests to > *explicitly* verify both SSL and clientAuth that will include some "false > positive" verifications, and some "test the test" checks. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org