[ 
https://issues.apache.org/jira/browse/SOLR-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15304104#comment-15304104
 ] 

David Smiley commented on SOLR-8583:
------------------------------------

This is certainly committable; I think you can commit it as-is if you want, or 
make further tweaks based on my remaining minor comments.  

You could move this line (that already existed) higher up so that you needn't 
re-pull it out in the highlighting alternate code
* int alternateFieldLen = params.getFieldInt(fieldName, 
HighlightParams.ALTERNATE_FIELD_LENGTH, 0);
* why the max(18,altFieldLen) ?  18 seems like a magic number.... if someone 
sets the alt field length to some silly low number then it's there prerogative 
to do so?

bq. If you search "keyword" on t_text you will not get any hits :-)

hehe, well, consider dismax with multiple fields.

Docs looks good, basically. I'll correct a small grammatical error.

> Apply highlighting to hl.alternateField
> ---------------------------------------
>
>                 Key: SOLR-8583
>                 URL: https://issues.apache.org/jira/browse/SOLR-8583
>             Project: Solr
>          Issue Type: Improvement
>          Components: highlighter
>    Affects Versions: 5.4
>            Reporter: Jan Høydahl
>            Assignee: Jan Høydahl
>              Labels: fallback, highlighter
>             Fix For: 6.1, master (7.0)
>
>         Attachments: SOLR-8583.patch, SOLR-8583.patch, SOLR-8583.patch, 
> SOLR-8583.patch, SOLR-8583.patch
>
>
> Today, you can configure hl.alternateField for highlighter to display if no 
> snippets were produced from original field. But the contents of the fallback 
> field is output without highlighting the original query terms.
> This issue will cause alternate field to be highlighted with no snippet 
> generation, and still respect max length. You can turn it off using new param 
> {{hl.highlightAlternate=false}}. Supported highlighters: Simple, FVH



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to