[ https://issues.apache.org/jira/browse/SOLR-8955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15311049#comment-15311049 ]
Trey Cahill commented on SOLR-8955: ----------------------------------- I uploaded a patch that will enable throttling for all requests, which is configurable (as per [~gpendleb] request), instead of throttling for each client by setting the parameter "globalthrottling=true". There's a few thing's that I'm not sure about in creating the patch: 1) Is having the parameter "globalthrottling" the best way to set/configure throttling? 2) Is this the best way to throttle for all requests to a node? 3) The best way to test this; currently, the patch uses test cases that started out as copies of the testRateLimitedReplication(). > ReplicationHandler should throttle across all requests instead of for each > client > --------------------------------------------------------------------------------- > > Key: SOLR-8955 > URL: https://issues.apache.org/jira/browse/SOLR-8955 > Project: Solr > Issue Type: Improvement > Components: replication (java), SolrCloud > Reporter: Shalin Shekhar Mangar > Labels: difficulty-easy, impact-medium, newdev > Fix For: 6.0, 6.1 > > Attachments: SOLR-8955.patch > > > SOLR-6485 added the ability to throttle the speed of replication but the > implementation rate limits each request. So e.g. the maxWriteMBPerSec is 1 > and 5 slaves request full replication then the effective transfer rate from > the master is 5 MB/second which is not what is often desired. > I propose to make the rate limit global (across all replication requests) > instead. -- This message was sent by Atlassian JIRA (v6.3.4#6332) --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org For additional commands, e-mail: dev-h...@lucene.apache.org