[
https://issues.apache.org/jira/browse/LUCENE-7194?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342606#comment-15342606
]
Karl Wright edited comment on LUCENE-7194 at 6/21/16 9:45 PM:
--------------------------------------------------------------
[~rcmuir]: Is this still needed? In SloppyMath.java I see the following:
{code}
// haversin
// TODO: remove these for java 9, they fixed Math.toDegrees()/toRadians() to
work just like this.
public static final double TO_RADIANS = Math.PI / 180D;
public static final double TO_DEGREES = 180D / Math.PI;
{code}
... which leads me to wonder if Java 9 was fixed and we should instead be using
Math.toDegrees()/toRadians() everywhere? Maybe [~thetaphi] knows?
was (Author: kwri...@metacarta.com):
[~rcmuir]: Is this still needed? In SloppyMath.java I see the following:
{code}
// haversin
// TODO: remove these for java 9, they fixed Math.toDegrees()/toRadians() to
work just like this.
public static final double TO_RADIANS = Math.PI / 180D;
public static final double TO_DEGREES = 180D / Math.PI;
{code}
... which leads me to wonder if Java 9 was fixed and we should instead be using
Math.toDegrees()/toRadians() everywhere?
> Ban Math.toRadians/toDegrees and remove all usages of it
> --------------------------------------------------------
>
> Key: LUCENE-7194
> URL: https://issues.apache.org/jira/browse/LUCENE-7194
> Project: Lucene - Core
> Issue Type: Bug
> Reporter: Robert Muir
> Assignee: Karl Wright
>
> The result of these methods is unreliable and changes across jvm versions: we
> cannot use these methods.
> The following program prints 0.7722082215479366 on previous versions of java
> but 0.7722082215479367 on java 9 because Math.toRadians is no longer doing
> the same thing:
> {code}
> public class test {
> public static void main(String args[]) throws Exception {
> System.out.println(Math.toRadians(44.244272));
> }
> }
> {code}
> This is because of https://bugs.openjdk.java.net/browse/JDK-4477961.
> I am not really sure its a bug, because the method says that the conversion
> is "generally inexact".
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
