[
https://issues.apache.org/jira/browse/SOLR-7374?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15344745#comment-15344745
]
Hrishikesh Gadre commented on SOLR-7374:
----------------------------------------
[~varunthacker] Thanks for the review. I think the changes look good. I have
one question though.
bq. 4. Merged the replication handler and core admin handler test in
TestHdfsBackupRestoreCore to one. We test it randomly
Wouldn't it be better to test both ways every time? I see that this pattern is
used extensively in other tests too. My main concern is that the probability of
one of the test not being executed in multiple iterations is > 0. If someone
makes any subsequent changes to this code, this unit test doesn't provide a
strong assurance that these changes are correct since one of the tests may not
have been executed at all. So developers end up diagnosing and fixing such
issues after committing the code (which could have been done before the first
commit itself).
I do think that random tests are very useful to test the Solr cloud behavior
(e.g. chaos monkey tests). But in this case, I am not sure if we need
randomness. Any thoughts?
> Backup/Restore should provide a param for specifying the directory
> implementation it should use
> -----------------------------------------------------------------------------------------------
>
> Key: SOLR-7374
> URL: https://issues.apache.org/jira/browse/SOLR-7374
> Project: Solr
> Issue Type: Bug
> Reporter: Varun Thacker
> Assignee: Mark Miller
> Fix For: 6.2
>
> Attachments: SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch,
> SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch, SOLR-7374.patch,
> SOLR-7374.patch, SOLR-7374.patch
>
>
> Currently when we create a backup we use SimpleFSDirectory to write the
> backup indexes. Similarly during a restore we open the index using
> FSDirectory.open .
> We should provide a param called {{directoryImpl}} or {{type}} which will be
> used to specify the Directory implementation to backup the index.
> Likewise during a restore you would need to specify the directory impl which
> was used during backup so that the index can be opened correctly.
> This param will address the problem that currently if a user is running Solr
> on HDFS there is no way to use the backup/restore functionality as the
> directory is hardcoded.
> With this one could be running Solr on a local FS but backup the index on
> HDFS etc.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org
