[ 
https://issues.apache.org/jira/browse/LUCENE-7340?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15353689#comment-15353689
 ] 

Daniel Collins commented on LUCENE-7340:
----------------------------------------

The only potential issue I see with the output as it stands with your patch, is 
that the bracketing suggests that the payload is part of the position 
information (at least that's how I would interpret it), when really its 
something separate?  But payloads aren't an area I know well, we came upon this 
bug by accident, so I don't feel that strongly about it.

Agreed, there is no real value in the number of payloads, I only added it as 
both terms and positions had counts, so it was purely for consistency with them.

> MemoryIndex.toString is broken if you enable payloads
> -----------------------------------------------------
>
>                 Key: LUCENE-7340
>                 URL: https://issues.apache.org/jira/browse/LUCENE-7340
>             Project: Lucene - Core
>          Issue Type: Bug
>          Components: modules/highlighter
>    Affects Versions: 5.4.1, 6.0.1, master (7.0)
>            Reporter: Daniel Collins
>            Assignee: David Smiley
>            Priority: Minor
>         Attachments: LUCENE-7340.diff, LUCENE-7340.diff, LUCENE-7340.patch
>
>
> Noticed this as we use Luwak which creates a MemoryIndex(true, true) storing 
> both offsets and payloads (though in reality we never put any payloads in it).
> We used to use MemoryIndex.toString() for debugging and noticed it broke in 
> Lucene 5.x  and beyond.  I think LUCENE-6155 broke it when it added support 
> for payloads?
> Creating default memoryindex (as all the tests currently do) works fine, as 
> does one with just offsets, it is just the payload version which is broken.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscr...@lucene.apache.org
For additional commands, e-mail: dev-h...@lucene.apache.org

Reply via email to