[
https://issues.apache.org/jira/browse/SOLR-9264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15355865#comment-15355865
]
Hrishikesh Gadre commented on SOLR-9264:
----------------------------------------
[~ shalinmangar] I think the patch looks good. Only couple of minor comments,
- Can we rename the "interestingCollections" and "interestingCollection"
variable to something like "collectionsWithLocalReplica" and
"collectionWithLocalReplica" ? It is a little difficult to understand what
"interesting" means in this context without reading the JIRA description...
- Is it possible for the callback to be delivered more than once? If yes then
we should probably add some defensive check before invoking the countDown
method on the latch.
> Optimize ZkController.publishAndWaitForDownStates
> -------------------------------------------------
>
> Key: SOLR-9264
> URL: https://issues.apache.org/jira/browse/SOLR-9264
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: 6.2, master (7.0)
>
> Attachments: SOLR-9264.patch
>
>
> ZkController.publishAndWaitForDownStates keeps looping over all collections
> in the cluster state to ensure that every replica hosted on the current node
> has been marked as down. This is wasteful when you have a large number of
> collections because each access to a non-watched collection gets data from
> ZK. Instead, we can watch the interesting collections (i.e. which have
> replicas hosted locally) and wait till we see the required state.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
