[ 
https://issues.apache.org/jira/browse/SOLR-8858?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15359129#comment-15359129
 ] 

ASF GitHub Bot commented on SOLR-8858:
--------------------------------------

Github user shalinmangar commented on a diff in the pull request:

    https://github.com/apache/lucene-solr/pull/47#discussion_r69316868
  
    --- Diff: 
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java ---
    @@ -910,8 +910,12 @@ protected void createMainQuery(ResponseBuilder rb) {
             additionalAdded = addFL(additionalFL, "score", additionalAdded);
           }
         } else {
    -      // reset so that only unique key is requested in shard requests
    -      sreq.params.set(CommonParams.FL, 
rb.req.getSchema().getUniqueKeyField().getName());
    +      if (rb.req.getSearcher().enableLazyFieldLoading) {
    +        // reset so that only unique key is requested in shard requests
    +        sreq.params.set(CommonParams.FL, 
rb.req.getSchema().getUniqueKeyField().getName());
    +      } else {
    +        sreq.params.set(CommonParams.FL, "*");
    --- End diff --
    
    I can see why this change was made but my point is that there is probably 
an assumption in the join queries or in the test (I haven't looked) which make 
it fail without this change.


> SolrIndexSearcher#doc() Completely Ignores Field Filters Unless Lazy Field 
> Loading is Enabled
> ---------------------------------------------------------------------------------------------
>
>                 Key: SOLR-8858
>                 URL: https://issues.apache.org/jira/browse/SOLR-8858
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 4.6, 4.10, 5.5
>            Reporter: Caleb Rackliffe
>              Labels: easyfix
>
> If {{enableLazyFieldLoading=false}}, a perfectly valid fields filter will be 
> ignored, and we'll create a {{DocumentStoredFieldVisitor}} without it.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to